[WIP] observability: add SessionTimer.Reset to re-anchor session start#1607
Merged
Conversation
Lets callers re-anchor the timer to the moment a participant actually joins, so wall-clock time accrued before that (auth, room setup, ICE establishment) is not counted toward reported/billed duration. Guards Advance/Reset with a mutex since the re-anchor happens on a different goroutine than the periodic reporter tick. Min-seconds/min-minutes options are preserved across Reset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
paulwe
approved these changes
Jun 11, 2026
paulwe
added a commit
that referenced
this pull request
Jun 12, 2026
#1607) * observability: add SessionTimer.Reset to re-anchor session start Lets callers re-anchor the timer to the moment a participant actually joins, so wall-clock time accrued before that (auth, room setup, ICE establishment) is not counted toward reported/billed duration. Guards Advance/Reset with a mutex since the re-anchor happens on a different goroutine than the periodic reporter tick. Min-seconds/min-minutes options are preserved across Reset. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * remove mutex * generated protobuf --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Paul Wells <paulwe@gmail.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets callers re-anchor the timer to the moment a participant actually joins, so wall-clock time accrued before that (auth, room setup, ICE establishment) is not counted toward reported/billed duration. Guards Advance/Reset with a mutex since the re-anchor happens on a different goroutine than the periodic reporter tick. Min-seconds/min-minutes options are preserved across Reset.